feat(cfnspec): cloudformation spec v18.6.0 #10762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivlaks
added
the
pr-linter/exempt-test
shivlaks
approved these changes
Oct 7, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shivlaks
added a commit
that referenced
this pull request
Oct 7, 2020
…tored properties in the `18.5` import, there the AWS::StepFunctions::Activity resource dropped the required name property and added one called Arn which was unintentional. A patch was added to restore the resource specification to previous state. Since #10762 has been merged, those properties have been restored in the resource specification as of `18.6`. The patch is no longer necessary.
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2020
…tored properties (#10764) in the `18.5` import, there the AWS::StepFunctions::Activity resource dropped the required name property and added one called Arn which was unintentional. A patch was added to restore the resource specification to previous state. Since #10762 has been merged, those properties have been restored in the resource specification as of `18.6`. The patch is no longer necessary. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
PatMyron
reviewed
Oct 8, 2020
Comment on lines
+27
to
+31
| * AWS::ImageBuilder::Component Name (__deleted__) | ||
| * AWS::ImageBuilder::DistributionConfiguration Name (__deleted__) | ||
| * AWS::ImageBuilder::ImagePipeline Name (__deleted__) | ||
| * AWS::ImageBuilder::ImageRecipe Name (__deleted__) | ||
| * AWS::ImageBuilder::InfrastructureConfiguration Name (__deleted__) |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.